Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: allow sys on local run #67

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

WilliamBergamin
Copy link
Contributor

Summary

Following the changes in slackapi/deno-slack-hooks#94

This PR allow locally run application to use the Deno.osRelease(); utility.

This should allow the use of the @slack/webapi library

Requirements (place an x in each [ ])

@WilliamBergamin WilliamBergamin added the enhancement New feature or request label Aug 29, 2024
@WilliamBergamin WilliamBergamin self-assigned this Aug 29, 2024
@WilliamBergamin WilliamBergamin requested a review from a team as a code owner August 29, 2024 15:23
@filmaj
Copy link
Contributor

filmaj commented Aug 29, 2024

Thanks for doing this! Let's hold off on merging this until we ROSI supports this and releases it first, though, otherwise we may give developers the false sense of security that using this system API is fine (while it's blocked for deployed apps).

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.88%. Comparing base (ed8a6f6) to head (f749f04).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #67   +/-   ##
=======================================
  Coverage   94.87%   94.88%           
=======================================
  Files          14       14           
  Lines         527      528    +1     
  Branches       88       88           
=======================================
+ Hits          500      501    +1     
  Misses         27       27           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants