-
Notifications
You must be signed in to change notification settings - Fork 638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add proxy support based on new Slack SDK v3 #318
Conversation
@rizkiarm: thanks for the contribution. i can see how this feature would be useful. would you please add some tests for the new functionality? if you need help with this, let us know and we can take a closer look. |
@rizkiarm ping! i'd still be happy to merge this change, but i need some tests. let me know if you want help with that and if you're still interested in contributing this change. if so, i'll also nee you to sign our CLA. you might have noticed that the initialization code for |
before landing this, we should update the documentation to show how to use this feature. |
i think this is duplicate of #372, since essentially we're talking about one environment variable either way, and documenting it (and fixing that issue) would solve this one too. |
This will add a proxy support using wsTransport for ws/wss, proxiedRequestTransport for http/https.
Proxy url can be configured by setting the environment variable
HUBOT_SLACK_PROXY
.