Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proxy support based on new Slack SDK v3 #318

Closed
wants to merge 3 commits into from

Conversation

rizkiarm
Copy link

@rizkiarm rizkiarm commented Jul 13, 2016

This will add a proxy support using wsTransport for ws/wss, proxiedRequestTransport for http/https.
Proxy url can be configured by setting the environment variable HUBOT_SLACK_PROXY.

@coveralls
Copy link

coveralls commented Jul 13, 2016

Coverage Status

Coverage decreased (-0.3%) to 57.343% when pulling 31d5559 on rizkiarm:add-proxy-support into 2aab972 on slackhq:v3-sdk-updates.

@coveralls
Copy link

coveralls commented Jul 13, 2016

Coverage Status

Coverage decreased (-0.3%) to 57.343% when pulling 31d5559 on rizkiarm:add-proxy-support into 2aab972 on slackhq:v3-sdk-updates.

@aoberoi
Copy link
Contributor

aoberoi commented Jan 5, 2017

@rizkiarm: thanks for the contribution. i can see how this feature would be useful. would you please add some tests for the new functionality? if you need help with this, let us know and we can take a closer look.

@aoberoi
Copy link
Contributor

aoberoi commented Oct 17, 2017

@rizkiarm ping! i'd still be happy to merge this change, but i need some tests. let me know if you want help with that and if you're still interested in contributing this change. if so, i'll also nee you to sign our CLA.

you might have noticed that the initialization code for SlackBot has changed. you should be able to remove your changes in index.coffee and use environment variables to define the options.

@aoberoi aoberoi added enhancement M-T: A feature request for new functionality docs M-T: Documentation work only labels Oct 17, 2017
@aoberoi
Copy link
Contributor

aoberoi commented Oct 17, 2017

before landing this, we should update the documentation to show how to use this feature.

@aoberoi
Copy link
Contributor

aoberoi commented Mar 30, 2018

i think this is duplicate of #372, since essentially we're talking about one environment variable either way, and documenting it (and fixing that issue) would solve this one too.

@aoberoi aoberoi closed this Mar 30, 2018
@aoberoi aoberoi added duplicate An issue for the same purpose already exists, and a link is in the comments and removed docs M-T: Documentation work only enhancement M-T: A feature request for new functionality labels Mar 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate An issue for the same purpose already exists, and a link is in the comments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants