Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add apps.manifest.* & tooling.tokens.rotate API support #1231

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

seratch
Copy link
Member

@seratch seratch commented Nov 7, 2023

This pull request adds the following API supports to this SDK:

To use these APIs, developers can generate their first refresh token on this page: https://api.slack.com/reference/manifests#config-tokens

Category (place an x in each of the [ ])

  • bolt (Bolt for Java)
  • bolt-{sub modules} (Bolt for Java - optional modules)
  • slack-api-client (Slack API Clients)
  • slack-api-model (Slack API Data Models)
  • slack-api-*-kotlin-extension (Kotlin Extensions for Slack API Clients)
  • slack-app-backend (The primitive layer of Bolt for Java)

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.

@seratch seratch added enhancement M-T: A feature request for new functionality project:slack-api-client project:slack-api-client project:slack-api-model project:slack-api-model labels Nov 7, 2023
@seratch seratch added this to the 1.36.0 milestone Nov 7, 2023
@seratch seratch self-assigned this Nov 7, 2023
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #1231 (a4892f2) into main (a091bd4) will decrease coverage by 0.40%.
The diff coverage is 34.40%.

@@             Coverage Diff              @@
##               main    #1231      +/-   ##
============================================
- Coverage     74.55%   74.15%   -0.40%     
- Complexity     4063     4086      +23     
============================================
  Files           437      440       +3     
  Lines         12857    12982     +125     
  Branches       1298     1310      +12     
============================================
+ Hits           9585     9627      +42     
- Misses         2511     2587      +76     
- Partials        761      768       +7     
Files Coverage Δ
.../java/com/slack/api/methods/MethodsRateLimits.java 99.09% <100.00%> (+0.02%) ⬆️
...slack/api/methods/impl/AsyncMethodsClientImpl.java 92.85% <100.00%> (+0.17%) ⬆️
...slack/api/token_rotation/tooling/ToolingToken.java 0.00% <0.00%> (ø)
.../com/slack/api/methods/impl/MethodsClientImpl.java 82.13% <50.00%> (-0.58%) ⬇️
...java/com/slack/api/methods/RequestFormBuilder.java 86.70% <59.37%> (-0.53%) ⬇️
...pi/token_rotation/tooling/ToolingTokenRotator.java 0.00% <0.00%> (ø)
..._rotation/tooling/store/FileToolingTokenStore.java 0.00% <0.00%> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@seratch seratch merged commit 1716f4a into slackapi:main Nov 7, 2023
4 of 5 checks passed
@seratch seratch deleted the app-manifest branch November 7, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality project:slack-api-client project:slack-api-client project:slack-api-model project:slack-api-model
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant