Issue-268: Websocket login respects https_proxy environment variable

slackapi · Nov 4, 2016 · e0ccfc7 · e0ccfc7
1 parent ce618b1
commit e0ccfc7
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/lib/clients/transports/ws.js b/lib/clients/transports/ws.js
@@ -16,9 +16,11 @@ var WebSocket = require('ws');
 var wsTransport = function wsTransport(socketUrl, opts) {
   var wsTransportOpts = opts || {};
   var wsOpts = {};
+  var proxyURL = wsTransportOpts.proxyURL || process.env.https_proxy;
 
-  if (wsTransportOpts.proxyURL) {
-    wsOpts.agent = new HttpsProxyAgent(wsTransportOpts.proxyUrl);
+  if (proxyURL) {
+    console.log('Using https proxy: ' + proxyURL);
+    wsOpts.agent = new HttpsProxyAgent(proxyURL);
   }
 
   return new WebSocket(socketUrl, wsOpts);