Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add types for radio buttons and checkboxes #964

Closed
3 tasks done
aoberoi opened this issue Feb 14, 2020 · 1 comment · Fixed by #966
Closed
3 tasks done

Add types for radio buttons and checkboxes #964

aoberoi opened this issue Feb 14, 2020 · 1 comment · Fixed by #966
Assignees
@seratch
Labels
enhancement M-T: A feature request for new functionality pkg:types applies to `@slack/types`

Comments

@aoberoi
Copy link
Contributor

aoberoi commented Feb 14, 2020

Description

Slack launched support for radio button groups and checkboxes in Block Kit. Let's get those types specified.

Requirements (place an x in each of the [ ])

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.
@aoberoi aoberoi added enhancement M-T: A feature request for new functionality pkg:types applies to `@slack/types` labels Feb 14, 2020
@seratch seratch mentioned this issue Feb 17, 2020
Merged
4 tasks
seratch added a commit to seratch/node-slack-sdk that referenced this issue Feb 17, 2020
@seratch
Fix slackapi#964 Add types for checkboxes
83c012c
@seratch seratch mentioned this issue Feb 17, 2020
Merged
2 tasks
@seratch
Copy link
Member

seratch commented Feb 17, 2020

I sent PRs to fix this issue. The radio_buttons element is already supported in both @slack/types and @slack/bolt.

@seratch seratch self-assigned this Feb 17, 2020
stevengill added a commit that referenced this issue Feb 18, 2020
@stevengill
Merge pull request #966 from seratch/checkboxes
4663d74 
Fix #964 Add types for checkboxes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seratch seratch

Labels
enhancement M-T: A feature request for new functionality pkg:types applies to `@slack/types`
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #964 Add types for checkboxes seratch/node-slack-sdk
2 participants
@seratch @aoberoi