Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #1566 Add admin.conversations.bulk{Archive|Delete|Move} API method support #1572

Merged
merged 3 commits into from
Dec 19, 2022

Conversation

hello-ashleyintech
Copy link
Contributor

@hello-ashleyintech hello-ashleyintech commented Dec 19, 2022

Summary

This PR fixes Issue #1566 and adds support for the following methods in the web-api package:

This PR also adds related tests in prod-server-integration-tests for these endpoints. Something to note is that with the addition of these tests, a new Env variable is required (SLACK_SDK_TEST_GRID_SECONDARY_WORKSPACE_ID), which is a workspace ID for a workspace in the same enterprise grid instance as the token for which SLACK_SDK_TEST_GRID_WORKSPACE_ADMIN_USER_TOKEN was generated. Integration tests were run locally to test and Node SDK updates were tested by importing the web-api package into a separate project and testing API calls with a script.

Requirements (place an x in each [ ])

@hello-ashleyintech hello-ashleyintech added the pkg:web-api applies to `@slack/web-api` label Dec 19, 2022
@hello-ashleyintech hello-ashleyintech requested review from seratch and a team December 19, 2022 23:40
@hello-ashleyintech hello-ashleyintech self-assigned this Dec 19, 2022
@seratch seratch added this to the [email protected] milestone Dec 19, 2022
@seratch seratch added the enhancement M-T: A feature request for new functionality label Dec 19, 2022
Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! Perfect 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality pkg:web-api applies to `@slack/web-api` semver:patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants