-
Notifications
You must be signed in to change notification settings - Fork 833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add request_file_info arg to files_upload_v2 method #1282
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1282 +/- ##
==========================================
+ Coverage 85.63% 85.67% +0.04%
==========================================
Files 84 84
Lines 7826 7827 +1
==========================================
+ Hits 6702 6706 +4
+ Misses 1124 1121 -3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
dbc14c0
to
d29fe50
Compare
This look great, thanks for taking the time to add this option! 🎉 My only concern is with the name I've been trying to think of a better name for the option. Perhaps Thanks again! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once we align on a name!
Sarah, FWIW, I like your name suggestion for the reason you gave. 👍 |
Thanks, request_file_info looks good to me too |
Summary
This pull request adds a new optional flag argument to files_upload_v2 method. When a developer passes full_file_info_required=False, the method skips fetching files.info response data for the uploaded files. Refer to #1277 for the context behind this change.
@srajiang I am thinking of adding the same flag to your Node SDK implementation. If you have any suggestions on better naming, I am happy to align for it.
Category (place an
x
in each of the[ ]
)/docs-src
(Documents, have you run./scripts/docs.sh
?)/docs-src-v2
(Documents, have you run./scripts/docs-v2.sh
?)/tutorial
(PythOnBoardingBot tutorial)tests
/integration_tests
(Automated tests for this library)Requirements (place an
x
in each[ ]
)python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh
after making the changes.