-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update RTM docs #1290
Update RTM docs #1290
Conversation
@ryan-aldaz - Woot, thanks for the contribution Ryan! Mind signing the CLA? |
Codecov Report
@@ Coverage Diff @@
## main #1290 +/- ##
==========================================
- Coverage 85.63% 85.62% -0.02%
==========================================
Files 84 84
Lines 7827 7827
==========================================
- Hits 6703 6702 -1
- Misses 1124 1125 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
docs-src/real_time_messaging.rst
Outdated
thread_ts=thread_ts | ||
) | ||
.. parsed-literal :: | ||
**rtm.start method deprecation after Nov 30th, 2021.** see details `here <https://api.slack.com/changelog/2021-10-rtm-start-to-stop>`_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
**rtm.start method deprecation after Nov 30th, 2021.** see details `here <https://api.slack.com/changelog/2021-10-rtm-start-to-stop>`_ | |
**rtm.start method has been deprecated for apps created after Nov 30th, 2021.** see details `here <https://api.slack.com/changelog/2021-10-rtm-start-to-stop>`_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't it fully deprecated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The announcement has this caveat:
For apps created before November 30, 2021, making API calls to https://slack.com/api/rtm.start will still technically succeed and return successful, but highly truncated responses even after September 27, 2022.
Seems like newly created apps after the date must use rtm.connect, and older apps will receive responses from rtm.start that are identical to rtm.connect. Is that your reading as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh i see Thank you!
I signed the CLA
e258db2
to
180a0e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for improving this document!
Summary
Fix #1145
Category (place an
x
in each of the[ ]
)/docs-src
(Documents, have you run./scripts/docs.sh
?)/docs-src-v2
(Documents, have you run./scripts/docs-v2.sh
?)/tutorial
(PythOnBoardingBot tutorial)tests
/integration_tests
(Automated tests for this library)Requirements (place an
x
in each[ ]
)python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh
after making the changes.