-
Notifications
You must be signed in to change notification settings - Fork 833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add interactivity_pointer as trigger_id alias to views.* APIs #1556
Conversation
@@ -5163,15 +5163,16 @@ async def users_profile_set( | |||
async def views_open( | |||
self, | |||
*, | |||
trigger_id: str, | |||
trigger_id: Optional[str] = None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only way to accept both in Python is to make both optional..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could add some logic that raises a TypeError if both fields are None
but this may not be needed if the API error mentions a missing trigger_id
or interactivity_pointer
field
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1556 +/- ##
==========================================
+ Coverage 84.88% 84.91% +0.02%
==========================================
Files 113 113
Lines 12546 12546
==========================================
+ Hits 10650 10653 +3
+ Misses 1896 1893 -3 ☔ View full report in Codecov by Sentry. |
Summary
views.open and views.push APIs now accept both trigger_id and interactivity_pointer
Category
/docs
(Documents)/tutorial
(PythOnBoardingBot tutorial)tests
/integration_tests
(Automated tests for this library)Requirements
python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh
after making the changes.