Skip to content

Commit

Permalink
log: also log error in DiscoverInstance when force discovery is speci…
Browse files Browse the repository at this point in the history
…fied (vitessio#11936)

Signed-off-by: Manan Gupta <[email protected]>

Signed-off-by: Manan Gupta <[email protected]>
  • Loading branch information
GuptaManan100 authored and timvaillancourt committed Mar 15, 2024
1 parent 7f738a7 commit 75c3a79
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions go/vt/vtorc/logic/orchestrator.go
Original file line number Diff line number Diff line change
Expand Up @@ -234,6 +234,10 @@ func DiscoverInstance(instanceKey inst.InstanceKey, forceDiscovery bool) {
backendLatency := latency.Elapsed("backend")
instanceLatency := latency.Elapsed("instance")

if forceDiscovery {
log.Infof("Force discovered - %+v, err - %v", instance, err)
}

if instance == nil {
failedDiscoveriesCounter.Inc(1)
_ = discoveryMetrics.Append(&discovery.Metric{
Expand All @@ -255,10 +259,6 @@ func DiscoverInstance(instanceKey inst.InstanceKey, forceDiscovery bool) {
return
}

if forceDiscovery {
log.Infof("Force discovered - %+v", instance)
}

_ = discoveryMetrics.Append(&discovery.Metric{
Timestamp: time.Now(),
InstanceKey: instanceKey,
Expand Down

0 comments on commit 75c3a79

Please sign in to comment.