slack-19.0: skip vexplain/schematracker tests in downgrade e2e …

…tests (#533) * `slack-19.0`: skip `vexplain` in downgrade e2e tests Signed-off-by: Tim Vaillancourt <[email protected]> * skip failing schematracker tests on v15 Signed-off-by: Tim Vaillancourt <[email protected]> --------- Signed-off-by: Tim Vaillancourt <[email protected]>
slackhq · Oct 17, 2024 · d9206dd · d9206dd
1 parent 987e2a6
commit d9206dd
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 0 deletions.
diff --git a/go/test/endtoend/vtgate/queries/vexplain/vexplain_test.go b/go/test/endtoend/vtgate/queries/vexplain/vexplain_test.go
@@ -53,6 +53,11 @@ func start(t *testing.T) (*mysql.Conn, func()) {
 }
 
 func TestVtGateVExplain(t *testing.T) {
+	if !utils.BinaryIsAtLeastAtVersion(16, "vtgate") {
+		t.Log("test requires version >= 16, skipping")
+		return
+	}
+
 	conn, closer := start(t)
 	defer closer()
 
@@ -136,6 +141,11 @@ func TestVtGateVExplain(t *testing.T) {
 }
 
 func TestVExplainPlan(t *testing.T) {
+	if !utils.BinaryIsAtLeastAtVersion(16, "vtgate") {
+		t.Log("test requires version >= 16, skipping")
+		return
+	}
+
 	conn, closer := start(t)
 	defer closer()
 
@@ -145,6 +155,11 @@ func TestVExplainPlan(t *testing.T) {
 }
 
 func TestVExplainAll(t *testing.T) {
+	if !utils.BinaryIsAtLeastAtVersion(16, "vtgate") {
+		t.Log("test requires version >= 16, skipping")
+		return
+	}
+
 	conn, closer := start(t)
 	defer closer()
 

diff --git a/go/test/endtoend/vtgate/schematracker/sharded/st_sharded_test.go b/go/test/endtoend/vtgate/schematracker/sharded/st_sharded_test.go
@@ -64,6 +64,12 @@ func TestMain(m *testing.M) {
 			return 1
 		}
 
+		// This test fails on slack-15.0, but we don't use schema tracking. Skip it.
+		if vtgateVer < 16 || vttabletVer < 16 {
+			fmt.Println("test requires version >= 16, skipping")
+			return 0
+		}
+
 		// For upgrade/downgrade tests.
 		if vtgateVer < 17 || vttabletVer < 17 {
 			// Then only the default sidecarDBName is supported.

diff --git a/go/test/endtoend/vtgate/schematracker/unsharded/st_unsharded_test.go b/go/test/endtoend/vtgate/schematracker/unsharded/st_unsharded_test.go
@@ -65,6 +65,12 @@ func TestMain(m *testing.M) {
 			return 1
 		}
 
+		// This test fails on slack-15.0, but we don't use schema tracking. Skip it.
+		if vtgateVer < 16 || vttabletVer < 16 {
+			fmt.Println("test requires version >= 16, skipping")
+			return 0
+		}
+
 		// For upgrade/downgrade tests.
 		if vtgateVer < 17 || vttabletVer < 17 {
 			// Then only the default sidecarDBName is supported.