Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slack-vitess-r14.0.5: backport vitessio/vitess#10619 pflag migration #120

Commits on Aug 28, 2023

  1. [cmd/*] Switch to pflag for all CLI flag parsing (vitessio#10619)

    * Switch to `pflag` for all parsing
    
    This transparently swaps the cli parsing library used by `internal/flag`
    from the standard library `flag` package to `spf13/pflag`.
    
    It also introduces hook points for packages throughout the vitess codebase
    to register their flags for either all commands using `servenv` or a
    particular subset of commands. This allows these packages to continue to
    define their flag variables in a package-private way, but without
    polluting the global flagset.
    
    Signed-off-by: Andrew Mason <[email protected]>
    
    * Workaround exit code difference between stdlib `flag` and `pflag`
    
    tl;dr stdlib `flag` has [this][1] and `pflag` does not
    
    [1]: golang/go@dcf0929
    
    Signed-off-by: Andrew Mason <[email protected]>
    
    * adjust test data for difference in spacing between pflag/stdflag
    
    Signed-off-by: Andrew Mason <[email protected]>
    
    * update lingering legacy flag tests
    
    Signed-off-by: Andrew Mason <[email protected]>
    
    * Update vtgate/tabletgateway.go to use new interface to isolate flags, update test data
    
    Signed-off-by: Andrew Mason <[email protected]>
    
    * update flags in java test code
    
    Signed-off-by: Andrew Mason <[email protected]>
    Andrew Mason authored and timvaillancourt committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    9bd5467 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2023

  1. Merge remote-tracking branch 'origin/slack-vitess-r14.0.5' into slack…

    …port-10619-slack-vitess-r14.0.5
    timvaillancourt committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    3bc3575 View commit details
    Browse the repository at this point in the history