Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slack-15.0: basic go.mod updates #382

Merged
merged 9 commits into from
May 30, 2024

Conversation

timvaillancourt
Copy link
Member

@timvaillancourt timvaillancourt commented May 29, 2024

Signed-off-by: Tim Vaillancourt <[email protected]>
@@ -48,7 +48,7 @@ var (
PRIMARY KEY (id)
) Engine=InnoDB;`
vschemaDDL = "alter vschema create vindex test_vdx using hash"
vschemaDDLError = fmt.Sprintf("Error 1105: cannot perform Update on keyspaces/%s/VSchema as the topology server connection is read-only",
vschemaDDLError = fmt.Sprintf("Error 1105 (HY000): cannot perform Update on keyspaces/%s/VSchema as the topology server connection is read-only",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New mysql driver version causes this change

@@ -264,7 +264,7 @@ func (bh *AZBlobBackupHandle) ReadFile(ctx context.Context, filename string) (io
}
blobURL := containerURL.NewBlobURL(obj)

resp, err := blobURL.Download(ctx, 0, azblob.CountToEnd, azblob.BlobAccessConditions{}, false)
resp, err := blobURL.Download(ctx, 0, azblob.CountToEnd, azblob.BlobAccessConditions{}, false, azblob.ClientProvidedKeyOptions{})
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New azure library causes this change

Signed-off-by: Tim Vaillancourt <[email protected]>
@timvaillancourt timvaillancourt marked this pull request as ready for review May 29, 2024 21:28
@timvaillancourt timvaillancourt requested a review from a team as a code owner May 29, 2024 21:28
roderickyao
roderickyao previously approved these changes May 29, 2024
tanjinx
tanjinx previously approved these changes May 29, 2024
Signed-off-by: Tim Vaillancourt <[email protected]>
@timvaillancourt timvaillancourt dismissed stale reviews from tanjinx and roderickyao via 7373227 May 29, 2024 21:56
Signed-off-by: Tim Vaillancourt <[email protected]>
@timvaillancourt
Copy link
Member Author

The go-metrics update caused a CI failure in statsd tests. I stole a fix from this upstream PR to fix this: https://github.com/vitessio/vitess/pull/11741/files#diff-3d282ee7d696fc323a0387553e146ec1561c19ecfca5f2dc43876fb1761350ca

Signed-off-by: Tim Vaillancourt <[email protected]>
Signed-off-by: Tim Vaillancourt <[email protected]>
Signed-off-by: Tim Vaillancourt <[email protected]>
@timvaillancourt timvaillancourt merged commit b2e4e0c into slack-15.0 May 30, 2024
194 checks passed
@timvaillancourt timvaillancourt deleted the go-mod-update-pt1-slack-15.0 branch May 30, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants