Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slack-19.0: backport PR #16852 #528

Merged
merged 3 commits into from
Oct 10, 2024
Merged

slack-19.0: backport PR #16852 #528

merged 3 commits into from
Oct 10, 2024

Conversation

timvaillancourt
Copy link
Member

@timvaillancourt timvaillancourt commented Oct 9, 2024 •
edited
Loading

Description

This PR backports vitessio#16852 to v19, a TL;DR:

This PR allows a EmergencyReparentShard/PlannedReparentShard request to contain the alias of the primary we expect to be the current primary for the action to succeed. If this alias is incorrect or stale, the reparent fails with an error indicating there is a failed precondition/mismatch.

Related Issue(s)

vitessio#16852

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

@timvaillancourt timvaillancourt requested a review from a team as a code owner October 9, 2024 17:26
@github-actions github-actions bot added this to the v19.0.5 milestone Oct 9, 2024
@timvaillancourt timvaillancourt merged commit 9885ab0 into slack-19.0 Oct 10, 2024
162 of 166 checks passed
@timvaillancourt timvaillancourt deleted the bp-pr16852_slack-19.0 branch October 10, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanjinx tanjinx tanjinx approved these changes

Assignees
No one assigned
Labels
upstream-backport An upstream backport v19 v21-backport
Projects
None yet
Milestone
v19.0.5
Development

Successfully merging this pull request may close these issues.
2 participants
@timvaillancourt @tanjinx