Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MacOSX 10.10.1 / iTerm 2.1] Interaction problems #164

Closed
mjurczyk opened this issue Jun 10, 2015 · 9 comments
Closed

[MacOSX 10.10.1 / iTerm 2.1] Interaction problems #164

mjurczyk opened this issue Jun 10, 2015 · 9 comments

Comments

@mjurczyk
Copy link
Contributor

After release [email protected] slap interaction does not automatically update (on click/on directional key).

Release 0.1.29 introduced some fix/feature (986b081?) that changed slap's behaviour under iTerm2 on Mac OS X.

Selection does not update unless user inputs text / selects another file. Mouse input and directional keys work and change selection, although it is not shown on the screen.


last working version:

@dbkaplun
Copy link
Member

@mjurczyk there is a race condition in NodeJS >0.10 and all versions of iojs that causes stdin to sporadically block on OSX (see libuv/libuv#304). This has been fixed as of [email protected], which will be included in the next release of NodeJS (see nodejs/node-v0.x-archive#25475).

Can you try installing on NodeJS 0.10 to confirm?

@rahsd
Copy link

rahsd commented Jun 10, 2015

with the latest nodejs from extra ppa for ubuntu I have the same issue.

@mjurczyk
Copy link
Contributor Author

@dbkaplun sorry, but that doesn't seem to be a case.
Tried following configurations ( + previously on io.js ):

Both work smoothly on [email protected], none runs smoothly on any further version.

Under _v0.9.12_ package could not be installed due to dependency errors:

.....
npm http GET https://registry.npmjs.org/bluebird
npm http 200 https://registry.npmjs.org/iconv-lite
npm ERR! Error: No compatible version found: iconv-lite@'^0.4.4'
npm ERR! Valid install targets:
npm ERR! ["0.1.0","0.1.1","0.1.2","0.1.3","0.1.4","0.2.0","0.2.1","0.2.3","0.2.4","0.2.5","0.2.6","0.2.7","0.2.8","0.2.9","0.2.10","0.2.11","0.4.0-pre","0.4.0-pre2","0.4.0-pre3","0.4.0","0.4.1","0.4.2","0.4.3","0.4.4","0.4.5","0.4.6","0.4.7","0.4.8","0.4.9","0.4.10"]
npm ERR!     at installTargetsError (/.nvm/v0.9.12/lib/node_modules/npm/lib/cache.js:679:10)
npm ERR!     at /.nvm/v0.9.12/lib/node_modules/npm/lib/cache.js:594:10
npm ERR!     at saved (....)
npm ERR!     at Object.oncomplete (fs.js:93:15)
npm ERR! If you need help, you may report this log at:
npm ERR!     <http://github.com/isaacs/npm/issues>
npm ERR! or email it to:
npm ERR!     <[email protected]>

npm ERR! System Darwin 14.0.0
npm ERR! command "...."
npm ERR! node -v v0.9.12
npm ERR! npm -v 1.2.12
....

dbkaplun added a commit to dbkaplun/slap that referenced this issue Jun 11, 2015
@dbkaplun
Copy link
Member

I've pushed an issue-164 branch that might fix your problems. Can you try npm install -g slap-editor/slap#issue-164 and see if that solves your issue?

I am using iTerm 2.1 as well and cannot reproduce. If that doesn't help, can you try npm install -g slap-editor/slap#<commit> for each commit between 0.1.28 (known good) and 0.1.29 (known bad) so we can determine what commit is to blame?

@mjurczyk
Copy link
Contributor Author

@dbkaplun unfortunately issue-164 did not fix the issue. I will try finding the breaking commit.

@mjurczyk
Copy link
Contributor Author

Just as I thought, 986b081 breaks the interactions.

After checking things in the commits I found that text-buffer is the problem. Limiting text-buffer version to 6.1.x fixes the problem on both node and iojs.

@dbkaplun
Copy link
Member

I've released 0.1.32 with your PR. Can you confirm the issue is fixed?

@mjurczyk
Copy link
Contributor Author

Version 0.1.32 works perfectly for me on iojs ;)

@dbkaplun
Copy link
Member

Excellent, closing. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants