Siddev3 #427
Open
Siddev3 #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abchugh
reviewed
Nov 14, 2024
Comment on lines
+14
to
+15
| const dbAcl = acls?.[0]; | ||
| if (!dbAcl) return res.status(404).send(`No ACL with id [${id}].`); |
There was a problem hiding this comment.
Suggested change
| const dbAcl = acls?.[0]; | |
| if (!dbAcl) return res.status(404).send(`No ACL with id [${id}].`); | |
| if (!acls?.[0]) return res.status(404).send(`No ACL with id [${id}].`); |
| const id = req.query.id as string; | ||
| if (!id) return res.status(422).send(`Missing param id.`); | ||
| const acls: any[] = await executeAndEndSet500OnError( | ||
| `SELECT * FROM AccessControlList where id = ?`, |
There was a problem hiding this comment.
don't select *, select id is sufficient
| if (!dbAcl) return res.status(404).send(`No ACL with id [${id}].`); | ||
|
|
||
| const members: ACLMembership[] = await executeAndEndSet500OnError( | ||
| 'SELECT * FROM ACLMembership WHERE parentACLId = ?', |
There was a problem hiding this comment.
Suggested change
| 'SELECT * FROM ACLMembership WHERE parentACLId = ?', | |
| 'SELECT memberUserId FROM ACLMembership WHERE parentACLId = ? AND memberUserId IS NOT NULL', |
| [directMembers], | ||
| res | ||
| ); | ||
| res |
There was a problem hiding this comment.
Make sure to also return the members whose entry is not found the database. Return empty string from this API.
And on the frontend show Unknown (in italics)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.