Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make _register_engine and _register_engine3 private #154

Merged
merged 1 commit into from
May 28, 2018

Conversation

hkdnet
Copy link
Contributor

@hkdnet hkdnet commented May 28, 2018

def self.foo does not define a private method though it is in a private context.
By using class << self and def foo, we can define a private method on Slim::Rails::RegisterEngine module.

`def self.foo` does not define a private method though
it is in a private context.
@januszm
Copy link
Contributor

januszm commented May 28, 2018

Nice catch, thanks.

@januszm januszm merged commit 7da9910 into slim-template:master May 28, 2018
@hkdnet hkdnet deleted the make-private branch May 29, 2018 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants