Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeout option #57

Open
wants to merge 3 commits into
base: development
Choose a base branch
from

Conversation

commadelimited
Copy link
Contributor

This PR adds a simple timeout option to the library. It's not the ideal end solution, which would allow developers to indicate their own timeout, perhaps when instantiating the library, but it's a good start.
#56

@keyan
Copy link

keyan commented Mar 19, 2018

@slimkrazy -- Thanks for the great library! We are trying to start using it in our application at the moment and the lack of timeout configuration is a big blocker. Any plan to get this merged? This is very important for production applications because as of right now there is usually no timeout for this call.

The optional timeout parameter specifies a timeout in seconds for blocking operations like the connection attempt (if not specified, the global default timeout setting will be used).

https://docs.python.org/3.1/library/urllib.request.html

The global default is None (no timeout): https://bugs.python.org/issue18417

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants