Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropping PHP 5.5 support #2178

Merged
merged 1 commit into from
Mar 21, 2017
Merged

Dropping PHP 5.5 support #2178

merged 1 commit into from
Mar 21, 2017

Conversation

Sam-Burns
Copy link
Contributor

Per discussion in #2175 , this PR explicitly drops PHP 5.5 support in the composer.json file. It also removes a build, and updates the docs.

@akrabat
Copy link
Member

akrabat commented Mar 19, 2017

👍 I'm surprised we hadn't already done this!

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.809% when pulling 62b5982 on Sam-Burns:php-version into 943b0be on slimphp:4.x.

@geggleto
Copy link
Member

@akrabat we were talking about 4.x being 7.x ...

@@ -12,10 +12,10 @@ Slim is a PHP micro-framework that helps you quickly write simple yet powerful w
It's recommended that you use [Composer](https://getcomposer.org/) to install Slim.

```bash
$ composer require slim/slim "^3.0"
$ composer require slim/slim "^4.0"
Copy link

@ivandokov ivandokov Mar 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is a mistake? Slim 4 is still work in progress.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is a mistake? Slim 4 is still work in progress.

This is a PR against 4.x, so it will be correct. There's an argument we should alias dev-4.x to 4.0 though.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I totally missed the target branch. Then @geggleto brings a good point. There were discussions for php 7.*

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7+ hasn't been agreed. Everyone agrees on dropping 5.5 though.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ivandokov There is an issue discussing language versions here: #2175. So far, the only agreement is that support for PHP 5.5 should be dropped, hence the pull request. But I agree it would be good to support PHP 7 only in the new version.

@akrabat akrabat added this to the 4.0 milestone Mar 21, 2017
@akrabat akrabat merged commit 62b5982 into slimphp:4.x Mar 21, 2017
akrabat added a commit that referenced this pull request Mar 21, 2017
@garnold
Copy link

garnold commented May 11, 2017

Possibly too late to the party, but Google App Engine Standard Environment only supports PHP 5.5.34. Would you guys reconsider 5.5 support?

@Sam-Burns
Copy link
Contributor Author

Sam-Burns commented May 11, 2017

@garnold I can't speak for the project's core maintainers, but much of the recent discussion has been as to whether to support PHP 5.6 or just put the minimum version to PHP 7.0, so I'm afraid it seems unlikely for Slim 4.

Please note that the project's core team, when I've spoken to them, have seemed very committed to supporting Slim 3 long-term, and it will remain an excellent choice of micro-framework after Slim 4 is released later this year.

PHP 5.5 critical security support died in the middle of last year, so I'm surprised to learn Google Cloud haven't upgraded yet. I am even now planning a miffed tweet.

@silentworks
Copy link
Member

@garnold it seems Google App Engine Flexible Environment supports PHP 5.6+, you might want to switch over to that as @Sam-Burns has said, PHP 5.5 is no longer supported by the PHP core team at all.

@garnold
Copy link

garnold commented May 12, 2017

@Sam-Burns @silentworks Thanks guys! I figured that would be the answer.

Trouble is according to Google, GAE SE is not going away anytime soon, yet they have no (public) plans to support 5.6/7.0 on GAE SE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants