Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix C++ build breakage caused by changed in stringify! output in ni… #5412

Merged
merged 1 commit into from
Jun 15, 2024

Commits on Jun 15, 2024

  1. Fix C++ build breakage caused by changed in stringify! output in ni…

    …ghtly Rust
    
    The C++ build started failling with nightly rust:
    rust-lang/rust#125174 changed the output of
    strignify! to contins more spaces between tokens, which we relied on to
    perform some type substitution from Rust types to C++ types, resulting
    in compilation errors:
    
    ```
    build/api/cpp/generated_include/slint_builtin_structs_internal.h:71:5: error: ‘Option’ does not name a type
       71 |     Option < core :: ops :: Range < i32 >> replacement_range;
          |     ^~~~~~
    build/api/cpp/generated_include/slint_builtin_structs_internal.h:75:14: error: ‘core’ was not declared in this scope
       75 |     Option < core :: ops :: Range < i32 >> preedit_selection;
          |              ^~~~
    ```
    
    Workaround by cleaning whitespace before matching the types.
    ogoffart committed Jun 15, 2024
    Configuration menu
    Copy the full SHA
    90739b1 View commit details
    Browse the repository at this point in the history