-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Angular2 support #39
base: master
Are you sure you want to change the base?
Angular2 support #39
Conversation
@sintro can you resolve merge conflicts (I think it's better revert changes in these files)? |
@denar90 it would be great if you wrote some tests. So I can jump in to hacking without breaking anything... |
@yury, should I remove changes in README and package in PR, or you will just ignore them when resolve conflicts? I also want to note, that I made this fork to creatу slm-brunch plugin, and I faced strange problem: I could not make html5 doctype, so every attributes which don't need value (disabled, etc) were compiled like It will work fine in future, but in 'slm' template engine, if you want to use it ng2 support, you have to ensure html5 format is enabled. Thus, I can offer to make it default value for compiling, how do you think? |
Also, do we need the dynamic code values for #hash attributes? I noted in README that I didn't implemented them (There is also no possibility of making code values for hash-attributes (like #localvar=alert('Hello world')). I think it is excessive functionality). I don't think that it is hard to do, and to do template engine more organic and intuitive, it should me implemented. |
I added base tests for angular2 supports
|
@sintro thanks for tests. What do you think about slim angular support I think we can port it. What do you think? I want to be close to slim. |
I've saw that discussions before I started to implement my version of Angular2 support for js-version of Slim.
|
I am creating this PR, so it will be possible to improve new code and may be fix some limitations, noted in my README. There is only one file with changes, which should me merged in base repo -
lib/parser.js