New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused kwargs from getattr #117

Merged

sloria merged 2 commits into sloria:master from hukkin:rm-kwargs

Dec 7, 2019

hukkin commented Dec 7, 2019 •

edited

Loading

Here's the signature of getattr from official Python docs: https://docs.python.org/3/reference/datamodel.html#object.getattr

We probably shouldn't allow **kwargs here.

Linting fails, but the fix is already in #116

hukkinj1 and others added 2 commits

December 7, 2019 16:22


          Remove unused kwargs from __getattr__

3dfadc0


          Merge branch 'master' into rm-kwargs

dbf9b7f

sloria merged commit 11a5381 into sloria:master

Owner

sloria commented Dec 7, 2019

Good catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet