Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix json parser not being descriptive enough (#209). #212

Merged
merged 3 commits into from
Mar 28, 2021
Merged

Fix json parser not being descriptive enough (#209). #212

merged 3 commits into from
Mar 28, 2021

Conversation

bvanelli
Copy link
Contributor

Old error message:

json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

New error message:

environs.EnvValidationError: Environment variable "JSON" invalid: Not a valid json.

sloria
sloria approved these changes Mar 28, 2021
View reviewed changes
Copy link
Owner

@sloria sloria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Made a few minor fixups.

Good to go once CI is passing.

@sloria sloria enabled auto-merge (squash) March 28, 2021 19:14
@sloria sloria merged commit 959caae into sloria:master Mar 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sloria sloria sloria approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bvanelli @sloria