-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configuration Mapper #333
Merged
Merged
Configuration Mapper #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radcortez
force-pushed
the
mapper
branch
2 times, most recently
from
June 30, 2020 20:04
1fd8a4f
to
d7906e1
Compare
@dmlloyd I've tried to fix some of the issues that I've found and write some additional tests. I believe this is going into the right track, but please let me know what do you think. |
Closed
dmlloyd
reviewed
Jul 13, 2020
implementation/src/main/java/io/smallrye/config/SmallRyeConfig.java
Outdated
Show resolved
Hide resolved
dmlloyd
reviewed
Jul 13, 2020
implementation/src/main/java/io/smallrye/config/mapper/ConfigMapping.java
Outdated
Show resolved
Hide resolved
dmlloyd
reviewed
Jul 13, 2020
implementation/src/main/java/io/smallrye/config/mapper/MappingContext.java
Outdated
Show resolved
Hide resolved
dmlloyd
reviewed
Jul 13, 2020
implementation/src/main/java/io/smallrye/config/mapper/ConfigMapping.java
Outdated
Show resolved
Hide resolved
dmlloyd
reviewed
Jul 13, 2020
implementation/src/main/java/io/smallrye/config/DefaultValuesConfigSource.java
Outdated
Show resolved
Hide resolved
dmlloyd
reviewed
Jul 13, 2020
implementation/src/main/java/io/smallrye/config/mapper/ConfigMapping.java
Outdated
Show resolved
Hide resolved
dmlloyd
reviewed
Jul 13, 2020
dmlloyd
reviewed
Jul 13, 2020
implementation/src/main/java/io/smallrye/config/DefaultValuesConfigSource.java
Outdated
Show resolved
Hide resolved
dmlloyd
reviewed
Jul 13, 2020
mapper/src/main/java/io/smallrye/config/mapper/CompareWith.java
Outdated
Show resolved
Hide resolved
dmlloyd
reviewed
Jul 15, 2020
implementation/src/main/java/io/smallrye/config/NameIterator.java
Outdated
Show resolved
Hide resolved
dmlloyd
reviewed
Jul 15, 2020
implementation/src/main/java/io/smallrye/config/mapper/ConfigurationInterface.java
Outdated
Show resolved
Hide resolved
dmlloyd
reviewed
Jul 15, 2020
implementation/src/main/java/io/smallrye/config/mapper/ConfigurationInterface.java
Outdated
Show resolved
Hide resolved
dmlloyd
reviewed
Jul 15, 2020
implementation/src/main/java/io/smallrye/config/mapper/ConfigurationValidationException.java
Outdated
Show resolved
Hide resolved
dmlloyd
reviewed
Jul 15, 2020
implementation/src/main/java/io/smallrye/config/KeyMapBackedConfigSource.java
Outdated
Show resolved
Hide resolved
@dmlloyd do you think we are ready to merge this and work the remaining pieces in subsequents PR's? |
dmlloyd
reviewed
Jul 17, 2020
implementation/src/main/java/io/smallrye/config/KeyMapBackedConfigSource.java
Outdated
Show resolved
Hide resolved
dmlloyd
reviewed
Jul 17, 2020
dmlloyd
reviewed
Jul 17, 2020
dmlloyd
reviewed
Jul 17, 2020
dmlloyd
reviewed
Jul 17, 2020
dmlloyd
reviewed
Jul 17, 2020
implementation/src/main/java/io/smallrye/config/SmallRyeConfig.java
Outdated
Show resolved
Hide resolved
Co-authored-by: David M. Lloyd <[email protected]>
Fixed some visibility modifiers.
radcortez
force-pushed
the
mapper
branch
2 times, most recently
from
July 31, 2020 15:30
d2e094f
to
f8c171d
Compare
dmlloyd
reviewed
Jul 31, 2020
implementation/src/main/java/io/smallrye/config/SmallRyeConfigBuilder.java
Outdated
Show resolved
Hide resolved
dmlloyd
approved these changes
Jul 31, 2020
🎉 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dmlloyd let me know if you think this is going into the right direction.
There is still a lot of things to take care and to try. Here are a few things that I did:
When a root cannot be found, one is created on the fly (experimental, I need to think better about this. We may want to merge with the current one).Support JavaBeans getter style method namesserver
, we only validate theserver
namespace.There is still a lot of things to work on (which I'm happy to do):
Improve SmallRyeConfig entry point APIs to access the Mapping