Expose Swagger configuration "tryItOutEnabled" property #1606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunolellis
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
MikeEdgar
approved these changes
Oct 9, 2023
There was a problem hiding this comment.
LGTM, thanks @brunolellis .
@phillip-kruger , I'll leave for you to merge in case you spot anything I didn't with the UI.
phillip-kruger
requested changes
Oct 9, 2023
| @@ -240,4 +240,17 @@ void testCreateWithSyntaxHighlightObject() throws IOException { | |||
|
|
|||
| assertTrue(s.contains("syntaxHighlight: { activated: true, theme: \"monokai\" },")); | |||
| } | |||
|
|
|||
| @Test | |||
| void testCreateWithTryItOutEnabledBoolean() throws IOException { | |||
There was a problem hiding this comment.
The default for tryItOut is enabled (see https://swagger.io/docs/open-source-tools/swagger-ui/usage/configuration/) so I would rather test false or disabled.
There was a problem hiding this comment.
The test only test that the value is set, so maybe this is actually fine.
phillip-kruger
approved these changes
Oct 9, 2023
| @@ -240,4 +240,17 @@ void testCreateWithSyntaxHighlightObject() throws IOException { | |||
|
|
|||
| assertTrue(s.contains("syntaxHighlight: { activated: true, theme: \"monokai\" },")); | |||
| } | |||
|
|
|||
| @Test | |||
| void testCreateWithTryItOutEnabledBoolean() throws IOException { | |||
There was a problem hiding this comment.
The test only test that the value is set, so maybe this is actually fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature exposes Swagger
tryItOutEnabledconfiguration property (doc)