maven plugin - Reduce amount of created jandex indexes. #957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Postremus
commented
Nov 7, 2021
Comment on lines
46
to
70
| ignoredArtifacts.add("org.graalvm.sdk:graal-sdk"); | ||
| ignoredArtifacts.add("org.yaml:snakeyaml"); | ||
| ignoredArtifacts.add("org.wildfly.common:wildfly-common"); | ||
| ignoredArtifacts.add("com.fasterxml.jackson.core:jackson-core"); | ||
| ignoredArtifacts.add("com.fasterxml.jackson.core:jackson-databind"); | ||
| ignoredArtifacts.add("io.quarkus:quarkus-vertx-http"); | ||
| ignoredArtifacts.add("io.smallrye:smallrye-open-api-core"); | ||
| ignoredArtifacts.add("io.smallrye.reactive:smallrye-mutiny-vertx-core"); | ||
| ignoredArtifacts.add("commons-io:commons-io"); | ||
| ignoredArtifacts.add("io.smallrye.reactive:mutiny"); | ||
| ignoredArtifacts.add("org.jboss.narayana.jta:narayana-jta"); | ||
| ignoredArtifacts.add("org.glassfish.jaxb:jaxb-runtime"); | ||
| ignoredArtifacts.add("com.github.ben-manes.caffeine:caffeine"); | ||
| ignoredArtifacts.add("org.hibernate.validator:hibernate-validator"); | ||
| ignoredArtifacts.add("io.smallrye.config:smallrye-config-core"); | ||
| ignoredArtifacts.add("com.thoughtworks.xstream:xstream"); | ||
| ignoredArtifacts.add("com.github.javaparser:javaparser-core"); | ||
| ignoredArtifacts.add("org.jboss:jandex"); | ||
|
|
||
| ignoredArtifacts.add("antlr"); | ||
| ignoredArtifacts.add("io.netty"); | ||
| ignoredArtifacts.add("org.drools"); | ||
| ignoredArtifacts.add("net.bytebuddy"); | ||
| ignoredArtifacts.add("io.vertx"); | ||
| ignoredArtifacts.add("org.hibernate"); | ||
| ignoredArtifacts.add("org.kie"); | ||
| ignoredArtifacts.add("org.postgresql"); | ||
| ignoredArtifacts.add("org.apache.httpcomponents"); |
There was a problem hiding this comment.
Not quit sure about having to maintain a list of blacklisted artifacts.
It does reduces the total time by about 1s though, which makes this justifiable (imo). The effect scales, if the project has more modules, and/or more dependencies.
WDYT?
Postremus
force-pushed
the
#954-backlist-and-cache
branch
3 times, most recently
from
baf9bf2
to
043a09d
Compare
|
Hi @Postremus - Thanks for this. Please resolve confict |
This introduces a blacklist of artifacts, for which no jandex index is ever created, since they won't have impact on the generated scheme. Also, cache the indexes that are created using their gavct
Postremus
force-pushed
the
#954-backlist-and-cache
branch
from
5705d92
to
45610d8
Compare
|
@phillip-kruger done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a blacklist of artifacts, for which no jandex index is ever created, since they won't have impact on the generated scheme.
Also, cache the indexes that are created using their gavct as key.
I tested this with a project with 2 modules, each module having 4 executions of the maven-plugin.
sroa-scanpackages.zip
I ran
mvn clean compile3 times, taking the average reported by mvn as total time.2.1.15: 19.067s
only blacklist: 7.003s
only cache: 5.471s
blacklist and cache: 4.447s
closes #954