-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
don't call asyncio.run for async handling #94
Conversation
Thanks @pmeier for this nice contribution. I think that it would be a good idea, if not too difficult, to have a specific test in your test file reproducing the issue #93 explicitly, so that it can ensure non-regression in the future. Indeed some |
@pmeier do you by any chance have any progress on this ? Let me know |
TBH, I completely forgot about this. Unfortunately, I'm swamped for the next month and will only have some dedicated time for this in October.
That is already implemented. |
@smarie I just did it now instead punting it to later. PTAL. |
Amazing ! I just made a minor comment. Could you please also add a changelog entry in a new 0.10.3 section ? https://github.com/smarie/mkdocs-gallery/blob/main/docs/changelog.md I'll release right after |
Thanks @pmeier ! |
This Pull request fixes #93
changelog.md
entries in the appropriate "in progress" section (not the last release one)b - My PR fixes some issues:
(Delete this section if not relevant)
@smarie This PR needs cleanup, but I wanted to get early feedback from you if the overall functionality is what you want.
I think it would make sense to move all the async stuff to a dedicated module or put them into
utils
. Any opinion here?