Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): drop support for node 4, add support for node 10 #55

Merged
merged 1 commit into from
Jul 8, 2018

Conversation

gurpreetatwal
Copy link
Contributor

BREAKING CHANGE: this library will no longer work on node 4,
we support all Node LTS version meaning 6, 8, 10

BREAKING CHANGE: this library will no longer work on node 4,
we support all Node LTS version meaning 6, 8, 10
Copy link
Contributor

@GregChan GregChan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we notifying developers before shipping this change? Can you talk to @esonmez about sending out an intercom message?

@sankethkatta
Copy link
Contributor

@GregChan we could check the Keen logs for the user agent to see which developers are actually using this SDK

@gurpreetatwal gurpreetatwal merged commit 8e0963f into master Jul 8, 2018
@gurpreetatwal gurpreetatwal deleted the drop-node-4 branch July 8, 2018 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants