core/capabilities/ccip: bump chainlink-ccip #1284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
include fixes from smartcontractkit/chainlink-ccip#60
asoliman92
reviewed
Aug 12, 2024
| @@ -0,0 +1,23 @@ | |||
| package superfakes | |||
There was a problem hiding this comment.
What's with the package name? mocks or something makes more sense to me.
There was a problem hiding this comment.
Its not really a mock, made this the pkg name mainly because it is hopefully short lived
There was a problem hiding this comment.
Maybe add a TODO in case it's forgotten.
asoliman92
reviewed
Aug 12, 2024
makramkd
commented
Aug 12, 2024
Comment on lines
+44
to
+53
| { | ||
| name: "allowOOO set to true makes no difference to final gas estimate", | ||
| args: args{dataLen: 5, numTokens: 2, extraArgs: makeExtraArgsV2(200_000, true)}, | ||
| want: 1_022_264, | ||
| }, | ||
| { | ||
| name: "allowOOO set to false makes no difference to final gas estimate", | ||
| args: args{dataLen: 5, numTokens: 2, extraArgs: makeExtraArgsV2(200_000, false)}, | ||
| want: 1_022_264, | ||
| }, |
There was a problem hiding this comment.
These test cases are new
Comment on lines
+98
to
+105
| { | ||
| name: "v2 extra args", | ||
| numRequests: 3, | ||
| dataLength: len([]byte{0x0, 0x0, 0x0, 0x0, 0x0, 0x0}), | ||
| numberOfTokens: 1, | ||
| extraArgs: makeExtraArgsV2(200_000, true), | ||
| want: 678_508, | ||
| }, |
asoliman92
approved these changes
Aug 12, 2024
rstout
approved these changes
Aug 12, 2024
|
dhaidashenko
pushed a commit
that referenced
this pull request
Sep 2, 2024
## Motivation Recent merges to chainlink-ccip have caused the integration test to break. ## Solution Include the gas estimator changes required as well as some token data reader changes. Include fixes from smartcontractkit/chainlink-ccip#60
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Recent merges to chainlink-ccip have caused the integration test to break.
Solution
Include the gas estimator changes required as well as some token data reader changes.
Include fixes from smartcontractkit/chainlink-ccip#60