Zp/update mockrouter #1427
Merged
Zp/update mockrouter #1427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically, allow for empty message with zero gas.
zeuslawyer
requested review from
makramkd,
elatoskinas,
RayXpub and
a team
as code owners
RensR
approved these changes
Sep 11, 2024
LCOV of commit
|
makramkd
approved these changes
Sep 12, 2024
|
valerii-kabisov-cll
pushed a commit
that referenced
this pull request
Oct 3, 2024
Specifically, allow for empty message with zero gas. ## Motivation EVM2EVMOffRamp checks the message for content and gaslimit and skips calling ccip receive if they're not present. Consequently the mock errors (ReceiverError) when sending only tokens to a smart contract. This update will help chainlink-local correctly process fork-based tests too. ## Solution The MockRouter implementation of _routeMessage was last updated in #669 and is out of sync with the logic in EVM2EVMOffRamp.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically, allow for empty message with zero gas.
Motivation
EVM2EVMOffRamp checks the message for content and gaslimit and skips calling ccip receive if they're not present.
Consequently the mock errors (ReceiverError) when sending only tokens to a smart contract. This update will help chainlink-local correctly process fork-based tests too.
Solution
The MockRouter implementation of _routeMessage was last updated in #669 and is out of sync with the logic in EVM2EVMOffRamp.