switch minSigners to f in RMNRemote & RMNHome
#1495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanRHall
requested review from
makramkd,
elatoskinas,
RayXpub and
a team
as code owners
LCOV of commit
|
RensR
reviewed
Oct 10, 2024
RayXpub
reviewed
Oct 10, 2024
RyanRHall
changed the title
f in RMNRemote & RMNHome
RyanRHall
changed the title
f in RMNRemote & RMNHomeminSigners to f in RMNRemote & RMNHome
RayXpub
approved these changes
Oct 10, 2024
|
RensR
reviewed
Oct 10, 2024
| @@ -92,10 +92,13 @@ contract RMNRemote is OwnerIsCreator, ITypeAndVersion, IRMNRemote { | |||
| Signature[] calldata signatures, | |||
| uint256 rawVs | |||
| ) external view { | |||
| (bool enabled, uint64 f) = (s_config.enabled, s_config.f); | |||
There was a problem hiding this comment.
That's pretty non-standard notation. Both are also used only once, does inlining te storage read really add a significant amount of gas?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In CCIPHome we have a requirement on the number of supporting oracles, but on RMNHome we have a laxer requirement of n >= minObservers which is not ideal (this was also in the initial sketch). If we have n=minObservers then liveness is not guaranteed. If we express f=minObservers-1, then we need at least n >= 2f+1 for liveness.
Similar story in RMNRemote for f=minSigners-1, where n >= 2f+1 would also be required for liveness.
Solution
Drop the minObservers/minSigners in favor of f for uniformity with CCIPConfig