MERC-6190: Remove bid/ask fields from Mercury v4 schema #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-cll
force-pushed
the
ml/v4-bid-ask
branch
2 times, most recently
from
844f204
to
61ae62b
Compare
martin-cll
changed the title
samsondav
previously requested changes
Aug 28, 2024
go.mod
Outdated
Comment on lines
79
to
80
| // until merged upstream: https://github.com/omissis/go-jsonschema/pull/264 | ||
| github.com/atombender/go-jsonschema => github.com/nolag/go-jsonschema v0.16.0-rtinianov |
There was a problem hiding this comment.
Oh we may just need this now to match common
There was a problem hiding this comment.
This is just to match common's go.mod file: https://github.com/smartcontractkit/chainlink-common/blob/main/go.mod#L111
go.mod
Outdated
Comment on lines
3
to
5
| go 1.22 | ||
|
|
||
| toolchain go1.22.6 |
There was a problem hiding this comment.
Can we avoid bumping versions in this PR?
There was a problem hiding this comment.
I kept the go and toolchain versions the same as chainlink-common.
martin-cll
force-pushed
the
ml/v4-bid-ask
branch
from
61ae62b
to
f61a9af
Compare
brunotm
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires:
Supports: