Eventually should connect because TxManager connection is async #1136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimroc
reviewed
Apr 25, 2019
core/store/tx_manager_test.go
Outdated
| @@ -40,7 +41,11 @@ func TestTxManager_CreateTx_Success(t *testing.T) { | |||
| }) | |||
| assert.NoError(t, app.StartAndConnect()) | |||
|
|
|||
| gomega.NewGomegaWithT(t).Eventually(func() bool { | |||
| return manager.Connected() | |||
| }).Should(gomega.Equal(true)) | |||
| require.True(t, manager.Connected()) | |||
There was a problem hiding this comment.
Can't you remove this line if you eventually assert it's true in the above line?
There was a problem hiding this comment.
Interesting to find this to be an issue, I'm a bit surprised but it makes sense. Should we drop a comment suggesting a future more global fix, since this pattern exists in other tests.
There was a problem hiding this comment.
Yeah I was keeping that in to ensure the test aborts, did some testing and gomega does hard fail the test. So removing now.
|
After some discussion offline, we're waiting on further thought and discussion to see if this indeed fixes the elusive mandelbug issue. |
|
Capturing for posterity's sake: https://awwapp.com/b/u5gledfmd/# |
asoliman92
pushed a commit
that referenced
this pull request
Aug 27, 2024
CCIP Config can go to larger size and any query from offchain components via rpc call can cause timeout issues add pagination to `getAllCCIPConfig` function which takes - pageSize - startIndex --------- Co-authored-by: app-token-issuer-infra-releng[bot] <120227048+app-token-issuer-infra-releng[bot]@users.noreply.github.com> Co-authored-by: Makram Kamaleddine <[email protected]>
asoliman92
pushed a commit
that referenced
this pull request
Aug 27, 2024
CCIP Config can go to larger size and any query from offchain components via rpc call can cause timeout issues add pagination to `getAllCCIPConfig` function which takes - pageSize - startIndex --------- Co-authored-by: app-token-issuer-infra-releng[bot] <120227048+app-token-issuer-infra-releng[bot]@users.noreply.github.com> Co-authored-by: Makram Kamaleddine <[email protected]>
asoliman92
pushed a commit
that referenced
this pull request
Aug 28, 2024
## Motivation CCIP Config can go to larger size and any query from offchain components via rpc call can cause timeout issues ## Solution add pagination to `getAllCCIPConfig` function which takes - pageSize - startIndex --------- Co-authored-by: app-token-issuer-infra-releng[bot] <120227048+app-token-issuer-infra-releng[bot]@users.noreply.github.com> Co-authored-by: Makram Kamaleddine <[email protected]>
asoliman92
pushed a commit
that referenced
this pull request
Aug 28, 2024
CCIP Config can go to larger size and any query from offchain components via rpc call can cause timeout issues add pagination to `getAllCCIPConfig` function which takes - pageSize - startIndex --------- Co-authored-by: app-token-issuer-infra-releng[bot] <120227048+app-token-issuer-infra-releng[bot]@users.noreply.github.com> Co-authored-by: Makram Kamaleddine <[email protected]>
asoliman92
pushed a commit
that referenced
this pull request
Aug 28, 2024
CCIP Config can go to larger size and any query from offchain components via rpc call can cause timeout issues add pagination to `getAllCCIPConfig` function which takes - pageSize - startIndex --------- Co-authored-by: app-token-issuer-infra-releng[bot] <120227048+app-token-issuer-infra-releng[bot]@users.noreply.github.com> Co-authored-by: Makram Kamaleddine <[email protected]>
asoliman92
pushed a commit
that referenced
this pull request
Aug 28, 2024
CCIP Config can go to larger size and any query from offchain components via rpc call can cause timeout issues add pagination to `getAllCCIPConfig` function which takes - pageSize - startIndex --------- Co-authored-by: app-token-issuer-infra-releng[bot] <120227048+app-token-issuer-infra-releng[bot]@users.noreply.github.com> Co-authored-by: Makram Kamaleddine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.