Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exclude jobspec internal fields from operator_ui definition #1296

Merged
merged 1 commit into from
May 30, 2019

Conversation

dimroc
Copy link
Contributor

@dimroc dimroc commented May 30, 2019

No longer has ID, CreatedAt, DeletedAt, UpdatedAt:

image

@dimroc dimroc requested a review from rupurt May 30, 2019 15:26
Copy link
Contributor

@rupurt rupurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👂

@dimroc dimroc marked this pull request as ready for review May 30, 2019 15:44
@dimroc dimroc merged commit d38f5b6 into master May 30, 2019
@dimroc dimroc deleted the operator/bugs/dont-copy-internal-spec-fields branch May 30, 2019 15:44
asoliman92 pushed a commit that referenced this pull request Aug 27, 2024
- Fix stale comment
- remove wrapper gen for the old mockRMN 
	- should no longer be used in offchain tests, use the real RMN instead
- Remove naming clash with RMN
asoliman92 pushed a commit that referenced this pull request Aug 28, 2024
- Fix stale comment
- remove wrapper gen for the old mockRMN 
	- should no longer be used in offchain tests, use the real RMN instead
- Remove naming clash with RMN
asoliman92 pushed a commit that referenced this pull request Aug 28, 2024
- Fix stale comment
- remove wrapper gen for the old mockRMN 
	- should no longer be used in offchain tests, use the real RMN instead
- Remove naming clash with RMN
asoliman92 pushed a commit that referenced this pull request Aug 28, 2024
- Fix stale comment
- remove wrapper gen for the old mockRMN 
	- should no longer be used in offchain tests, use the real RMN instead
- Remove naming clash with RMN
asoliman92 pushed a commit that referenced this pull request Aug 28, 2024
- Fix stale comment
- remove wrapper gen for the old mockRMN 
	- should no longer be used in offchain tests, use the real RMN instead
- Remove naming clash with RMN
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants