Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ccip-3535 env abstraction updated #14598

Merged
merged 18 commits into from
Sep 30, 2024
Merged

Conversation

AnieeG
Copy link
Contributor

@AnieeG AnieeG commented Sep 27, 2024

Requires

Resolves

@AnieeG AnieeG requested review from a team as code owners September 27, 2024 22:40
@AnieeG
Copy link
Contributor Author

AnieeG commented Sep 27, 2024

@AnieeG AnieeG closed this Sep 27, 2024
@AnieeG AnieeG reopened this Sep 27, 2024
connorwstein
connorwstein previously approved these changes Sep 30, 2024
if idToAccept == "" {
return fmt.Errorf("no job proposal found for job spec %s", spec)
}
aaprovedSpec, err := n.gqlClient.ApproveJobProposalSpec(ctx, idToAccept, false)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

@cl-sonarqube-production
Copy link

Copy link
Contributor

@b-gopalswami b-gopalswami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AnieeG AnieeG added this pull request to the merge queue Sep 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 30, 2024
@AnieeG AnieeG added this pull request to the merge queue Sep 30, 2024
Merged via the queue into develop with commit 02472a6 Sep 30, 2024
147 checks passed
@AnieeG AnieeG deleted the ccip-3535-env-abstraction-updated branch September 30, 2024 18:37
AnieeG added a commit that referenced this pull request Sep 30, 2024
* env changes

* changes

* lint

* jd changes

* fix typo

---------

Co-authored-by: Connor Stein <[email protected]>

updates
AnieeG added a commit that referenced this pull request Sep 30, 2024
* env changes

* changes

* lint

* jd changes

* fix typo

---------

Co-authored-by: Connor Stein <[email protected]>

updates

change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants