Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unreferenced unused key files. #14706

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Remove unreferenced unused key files. #14706

wants to merge 4 commits into from

Conversation

pavel-raykov
Copy link
Collaborator

@pavel-raykov pavel-raykov commented Oct 9, 2024 •
edited by jira bot
Loading

Trying to remove unused files BCF-3414.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024 •
edited
Loading

WF: CI Core#972a527

No errors found in this run. 🎉

@pavel-raykov pavel-raykov marked this pull request as ready for review October 10, 2024 14:30
@pavel-raykov pavel-raykov requested a review from a team as a code owner October 10, 2024 14:30
samsondav
samsondav approved these changes Oct 11, 2024
View reviewed changes
Copy link
Collaborator

@samsondav samsondav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's probably been long enough now that this is safe to remove. You might consider deleting the old table as well.

RyanRHall
RyanRHall approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@RyanRHall RyanRHall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to @samsondav - I would suggest we delete the old tables too

@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmank88 jmank88 jmank88 approved these changes

@samsondav samsondav samsondav approved these changes

@RyanRHall RyanRHall RyanRHall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pavel-raykov @jmank88 @samsondav @RyanRHall