Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rm CCIP 1.0/1.1 code #14751

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

Rm CCIP 1.0/1.1 code #14751

wants to merge 10 commits into from

Conversation

RensR
Copy link
Contributor

@RensR RensR commented Oct 14, 2024

Remove CCIP 1.0/1.1 code. This version has not been running on any mainnet for almost a year now. The 1.2 logic imported various aspects, which have been copy pasted into the 1.2 logic before deleting 1.0. There should be no impact on the behaviour of 1.2/1.5/1.6.

Copy link
Contributor

github-actions bot commented Oct 14, 2024

WF: CI Core#0f88539

No errors found in this run. 🎉

@smartcontractkit smartcontractkit deleted a comment from github-actions bot Oct 14, 2024
Copy link
Contributor

github-actions bot commented Oct 15, 2024

WF: CI Core#1ccd8ee

No errors found in this run. 🎉

@RensR RensR marked this pull request as ready for review October 15, 2024 09:06
@RensR RensR requested a review from a team as a code owner October 15, 2024 09:06
@RensR RensR requested a review from ilija42 October 15, 2024 09:06
Copy link
Contributor

github-actions bot commented Oct 15, 2024

Below is an analysis created by an LLM. Be mindful of hallucinations and verify accuracy.

WF: CI Core#7d43fbe

1. Incomplete read error during solc-select installation:[make generate]

Source of Error:
Traceback (most recent call last):
 File "/home/runner/.local/bin/solc-select", line 8, in <module>
 sys.exit(solc_select())
 File "/home/runner/.local/lib/python3.10/site-packages/solc_select/__main__.py", line 59, in solc_select
 install_artifacts(args.get(INSTALL_VERSIONS))
 File "/home/runner/.local/lib/python3.10/site-packages/solc_select/solc_select.py", line 91, in install_artifacts
 releases = get_available_versions()
 File "/home/runner/.local/lib/python3.10/site-packages/solc_select/solc_select.py", line 249, in get_available_versions
 list_json = urllib.request.urlopen(list_url).read()
 File "/usr/lib/python3.10/http/client.py", line 482, in read
 s = self._safe_read(self.length)
 File "/usr/lib/python3.10/http/client.py", line 633, in _safe_read
 raise IncompleteRead(data, amt-len(data))
http.client.IncompleteRead: IncompleteRead(15732 bytes read, 26488 more expected)

Why: The error occurred because the solc-select tool failed to completely download the list of available Solidity compiler versions. This could be due to network issues or server-side problems.

Suggested fix: Ensure stable network conditions. If the issue persists, consider manually specifying the Solidity compiler version or using a different method/tool to manage Solidity compiler versions.

2. Error while building liquiditymanager wrapper:[make generate]

Source of Error:
failure while building liquiditymanager wrapper, stderr: Fatal: Failed to read input ABI: open ../../../contracts/solc/v0.8.24/LiquidityManager/LiquidityManager.abi: no such file or directory
: exit status 1
exit status 1
core/gethwrappers/liquiditymanager/go_generate.go:6: running "go": exit status 1

Why: The build process failed because it could not find the ABI file for the LiquidityManager contract. This indicates that the contract might not have been compiled successfully, or the ABI file was not generated or is misplaced.

Suggested fix: Verify that the LiquidityManager contract is correctly compiled and the ABI file is generated in the expected directory. Ensure that all paths in the build scripts are correctly set to locate the ABI files.

3. Contract code size exceeds the limit:[make generate]

Source of Error:
Warning: Contract code size is 28644 bytes and exceeds 24576 bytes (a limit introduced in Spurious Dragon). This contract may not be deployable on Mainnet. Consider enabling the optimizer (with a low "runs" value!), turning off revert strings, or using libraries.
  --> /home/runner/work/chainlink/chainlink/contracts/src/v0.8/ccip/offRamp/OffRamp.sol:33:1:
 |
33 | contract OffRamp is ITypeAndVersion, MultiOCR3Base {
 | ^ (Relevant source part starts here and spans across multiple lines).

Why: The OffRamp contract's compiled code size exceeds the Ethereum mainnet's limit. This can prevent the contract from being deployed.

Suggested fix: Optimize the contract by enabling the Solidity optimizer in the compilation settings, reducing the number of runs to a lower value, simplifying the contract logic, or splitting the contract into smaller contracts. Additionally, consider removing unnecessary revert strings or using more libraries to share code between contracts.

@cl-sonarqube-production
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants