Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add aptos support in ocr3 config #14784

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

add aptos support in ocr3 config #14784

wants to merge 2 commits into from
+664 −24

Conversation

krehermann
Copy link
Contributor

@krehermann krehermann commented Oct 15, 2024 •
edited
Loading

KS-478

add aptos key support in deployment library

this changes ensures that the generated ocr3 config includes the aptos keys.

it makes aptos ocr2 bundle required for nodes running ocr3 capability. this may be overkill in the long run if/when there are multiple ocr3 dons, but it is ok and correct for now, and will prevent mistakes in the short term

@krehermann krehermann requested review from a team as code owners October 15, 2024 22:51
@krehermann krehermann marked this pull request as draft October 15, 2024 23:12
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 15, 2024 •
edited
Loading

Below is an analysis created by an LLM. Be mindful of hallucinations and verify accuracy.

WF: CI Core#d2742b9

1. External service temporarily unavailable:Flakey Test Detection

Source of Error: 
Flakey Test Detection	Re-run tests	2024-10-15T23:44:41.5404724Z 2024/10/15 23:44:41 Error re-running flakey tests: push request failed: status=503, body=<html>
Flakey Test Detection	Re-run tests	2024-10-15T23:44:41.5406630Z <head><title>503 Service Temporarily Unavailable</title></head>
Flakey Test Detection	Re-run tests	2024-10-15T23:44:41.5407902Z <body>
Flakey Test Detection	Re-run tests	2024-10-15T23:44:41.5408686Z <center><h1>503 Service Temporarily Unavailable</h1></center>
Flakey Test Detection	Re-run tests	2024-10-15T23:44:41.5412298Z <hr><center>nginx</center>
Flakey Test Detection	Re-run tests	2024-10-15T23:44:41.5412878Z </body>
Flakey Test Detection	Re-run tests	2024-10-15T23:44:41.5413313Z </html>
Flakey Test Detection	Re-run tests	2024-10-15T23:44:41.5436564Z ##[error]Process completed with exit code 1.

Why: The error occurred because an external service was temporarily unavailable, as indicated by the HTTP 503 status code returned by the server.

Suggested fix: Implement retry logic with exponential backoff or check the status of the external service before attempting to push requests.

@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
1 New issue
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

@krehermann krehermann marked this pull request as ready for review October 16, 2024 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@archseer archseer archseer approved these changes

@vyzaldysanchez vyzaldysanchez Awaiting requested review from vyzaldysanchez

@cedric-cordenier cedric-cordenier Awaiting requested review from cedric-cordenier

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krehermann @archseer