Extract the dropdown menu from VRF v2 cost calculator #1446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simkasss
requested review from
dwightjl,
ritika-b,
aelmanaa,
thedriftofwords and
yacine-benichou
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
simkasss
force-pushed
the
extract-dropdown
branch
from
33705f3
to
8a164f3
Compare
simkasss
force-pushed
the
extract-dropdown
branch
from
8a164f3
to
b81d4fb
Compare
yacine-benichou
force-pushed
the
extract-dropdown
branch
from
311a179
to
d12ba33
Compare
yacine-benichou
previously approved these changes
Aug 9, 2023
yacine-benichou
force-pushed
the
extract-dropdown
branch
from
8fbaf11
to
1a0a86b
Compare
…st selected network on reload
…cted for the first time + Added condition to render costTable only when network is defined
yacine-benichou
force-pushed
the
extract-dropdown
branch
from
fa261a9
to
5d80d00
Compare
yacine-benichou
approved these changes
Sep 5, 2023
dwightjl
suggested changes
Sep 6, 2023
dwightjl
approved these changes
Sep 6, 2023
Merged
dorianbayart
pushed a commit
to dorianbayart/documentation
that referenced
this pull request
Dec 25, 2023
…it#1446) * extract-dropdown * remove mainChainName useState * improve useQueryString hook * improve getNetworkFromQueryString * return null * Remove useless DropdownMenu component + fill dropdown input with latest selected network on reload * Refactor CostTable component to fix bugs in getting state values * Fix bug where API call was made with undefined or null input * Add additional states to reducer state to have a single source of truth * Implement throttle for API calls * Remove logging * WIP to fix API call rate limit bug * Fixed issue where loading text did not appear when a network was selected for the first time + Added condition to render costTable only when network is defined * Use env variables to get VRF calculator API url + clean code * Remove comments in methodCheckbox component * Fix type errors in CostTable.test.ts file * Empty commit * account test * new email set * empty commit * Empty commit * Use env variable in costTable test file * Remove env variable use * fix lint issue * Update src/features/data/chains.ts --------- Co-authored-by: Yacine Benichou <[email protected]> Co-authored-by: Yacine Benichou <[email protected]> Co-authored-by: Yacine Benichou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates issues
Relates #1423
Description
The dropdown menu is extracted from the VRF v2 cost calculator in order to make it reusable in other components.
Changes
queryStringparameter to networks data, in order to easier create and access search parametersgetNetworkFromQueryStringfunction, in order to get chain network object from search parametersuseQueryString, in order to get information about selected chain and network from urluseQueryStringto use URLSearchParams instead of query-string, because URLSearchParams is built-in