[Feature] Crypto volatility index adapter (by COTI) #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boxhock
suggested changes
Nov 11, 2020
There was a problem hiding this comment.
Thanks for making this PR! Please see the comments that I left. I also see that the adapter is written in JS, but follows some of the structure we use for TS adapters.
We are working on moving more and more over to TS. Would you be able to rewrite this to TS, following the structure in the example adapter? It shouldn't be that big of a difference, just adding some types and replacing callbacks with async/await.
|
updated the adapter to TS as requested |
boxhock
suggested changes
Nov 27, 2020
boxhock
suggested changes
Nov 27, 2020
boxhock
suggested changes
Dec 17, 2020
boxhock
suggested changes
Dec 17, 2020
yonine
force-pushed
the
feature/crypto-volatility-index
branch
2 times, most recently
from
f8f3baf
to
9515a4c
Compare
boxhock
suggested changes
Jan 5, 2021
yonine
force-pushed
the
feature/crypto-volatility-index
branch
2 times, most recently
from
18abda3
to
b78b1f7
Compare
boxhock
suggested changes
Jan 13, 2021
boxhock
suggested changes
Jan 14, 2021
heartbeat remove axios
yonine
force-pushed
the
feature/crypto-volatility-index
branch
from
7d34cbc
to
50f89a5
Compare
boxhock
approved these changes
Jan 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
An external adapter for calculating the Crypto volatility index (CVX)