-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Validator Input Options Behavior #1579
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a5257b6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 158 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
austinborn
changed the title
Add uppercase as options for xbto
Update Validator Input Options Behavior
Feb 17, 2022
justinkaseman
approved these changes
Feb 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for that! LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1531
Description
In line 22 of normalize/index.ts, the Validator runs without throwing errors and below that undefined values are removed. If an input is not in the options set then an error would be thrown, but due to
shouldThrowError: false
it just returns undefined and is removed. Then in a second pass to Validator the value is set to the default.Changes
shouldThrowError = false
Steps to Test
Quality Assurance
yarn changeset
if adapter source code was changed<ADAPTER_PACKAGE>/schemas/env.json
and<ADAPTER_PACKAGE>/README.md
infra-k8s
configuration file.feature/x
,chore/x
,release/x
,hotfix/x
,fix/x
) or is created from Clubhouse/Shortcut