DNS query and record check adapters #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
krebernisak
suggested changes
Dec 16, 2020
dns-query/src/adapter.ts
Outdated
| } | ||
|
|
||
| const result = await Requester.request({ | ||
| url: endpoints[dnsProvider], |
There was a problem hiding this comment.
Suggested change
| url: endpoints[dnsProvider], | |
| url: config.endpoint || endpoints[config.provider], |
RodrigoAD
commented
Dec 17, 2020
RodrigoAD
commented
Dec 17, 2020
RodrigoAD
commented
Dec 17, 2020
krebernisak
suggested changes
Dec 17, 2020
krebernisak
reviewed
Dec 17, 2020
krebernisak
approved these changes
Dec 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes two new adapters:
dns-query: Let query DNS over Httpsdns-record-check: Composite adapter that relies ondns-query, and check if a certain record exists in the DNS