-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/logger #212
Feature/logger #212
Conversation
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
Addresses #204 that was experienced when using the Node.js Error class:
|
4da77e9
to
9826a0f
Compare
9d3c557
to
c1d335d
Compare
@krebernisak Left some reasoning on why I made certain changes |
I've been playing with it, this is great. Just something I noticed, when there's an internal error, this is sent to the client as well. I don't know if this is the behavior we want |
I was wondering about which behaviour we want there too. My thought process is that we are open source and want to empower people to debug on their own. @krebernisak thoughts? This is related to that first change that you requested. |
My thoughts are that we should handle most/all of errors, output them with correct status codes and appropriate messages. We have work to do here. Internal errors should be caught, mapped to a HTTP 500 status code and construct an appropriate message. Something like |
c1d335d
to
0eb9cc9
Compare
@krebernisak Well said for a direction forward. Agreed that there is more work to do here with what response the user receives. I reverted the code that had requested changes, leaving this PR to be:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @justinkaseman!
Description
Node operator's log files have been growing very large. The Coin Paprika adapter for example had a >100Gb logfile.
This PR removes the log emitted when a response is returned to a request. Logs will still be shown on error or when LOG_LEVEL="debug".
Additionally some other logs that should probably be better served to debug level logs are changed to be so.
Ticket
#176137608