Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CMC API for multiple currencies with the same symbol #228

Merged
merged 5 commits into from
Jan 13, 2021
Merged

Fix CMC API for multiple currencies with the same symbol #228

merged 5 commits into from
Jan 13, 2021

Conversation

krebernisak
Copy link
Contributor

No description provided.

@krebernisak krebernisak added the bug Something isn't working label Jan 13, 2021
tyrion70
tyrion70 previously approved these changes Jan 13, 2021
View reviewed changes
Copy link
Collaborator

@tyrion70 tyrion70 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my staging and mainnet env, looks good!

boxhock
boxhock previously approved these changes Jan 13, 2021
View reviewed changes
Copy link
Contributor

@boxhock boxhock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're doing fixes for the other versions in different PRs, this looks good.

@krebernisak krebernisak dismissed stale reviews from boxhock and tyrion70 via 2a811cb January 13, 2021 16:30
RodrigoAD
RodrigoAD approved these changes Jan 13, 2021
View reviewed changes
Copy link
Member

@RodrigoAD RodrigoAD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krebernisak krebernisak merged commit 29fcecb into master Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RodrigoAD RodrigoAD RodrigoAD approved these changes

@boxhock boxhock Awaiting requested review from boxhock

@tyrion70 tyrion70 Awaiting requested review from tyrion70

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@krebernisak @boxhock @tyrion70 @RodrigoAD