dxfeed-secondary adapter #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
thodges-gh
suggested changes
Jan 28, 2021
There was a problem hiding this comment.
Just a quick note to clarify the secondary-market's usage. We'll be using it only for symbols which are reported from two different markets, like TSLA. So that on the primary adapter supplying the base of TSLA pulls from one market, then the other on the secondary adapter.
thodges-gh
approved these changes
Jan 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A quick secondary adapter to provide support for the
TSLAbase to convert toTSLA.US:TEIAlso brings along the TS migration of
dxfeedfrom #234 for easier importing.Caveats
dxfeed API currently down?
Ticket
176704940