-
Notifications
You must be signed in to change notification settings - Fork 45
feat: working Agoric initiator #73
feat: working Agoric initiator #73
Conversation
Hi @michaelfig, thanks for the good work. If you could add the necessary tests it would be ready |
dbfb35b
to
48b891d
Compare
R4R! |
e09bce1
to
c708815
Compare
c708815
to
e8d6399
Compare
@RodrigoAD this is ready to go, IMO. Do note that the Required "imports" check seems to be misconfigured. Instead, it should be "golang/static / Imports". Could you please change this setting in the Github configuration for this repository? |
e8d6399
to
c109727
Compare
@RodrigoAD @rigario this is ready for review, PTAL. |
Overall looks good, just this final detail. We've recently added prometheus metrics exporting, if you could include it as well. You can follow this: external-initiator/blockchain/bsn-irita.go Line 141 in c2e16a0
|
09730c8
to
7875857
Compare
Done! R4R as soon as the tests pass. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @michaelfig !
Now working end-to-end with smartcontractkit/external-adapters-js#114 and https://github.com/Agoric/dapp-oracle