Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added tasks back in to starter kit #36

Merged
merged 4 commits into from
Oct 19, 2021
Merged

added tasks back in to starter kit #36

merged 4 commits into from
Oct 19, 2021

Conversation

pappas999
Copy link
Collaborator

@pappas999 pappas999 commented Sep 2, 2021 •
edited
Loading

Addresses #35

the Fund link (and maybe read price feed) task can then be turned into a plugin separately

@pappas999 pappas999 mentioned this pull request Sep 2, 2021
Closed
PatrickAlphaC
PatrickAlphaC suggested changes Oct 11, 2021
View reviewed changes
Copy link
Contributor

@PatrickAlphaC PatrickAlphaC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just add back in the fund-link plugin. I think this one is good to be an external plugin.

Tests aren't passing without it.

hardhat.config.js Show resolved Hide resolved
@pappas999
added fund task plugin back in,
224e9f2 
also set private_key as the default .env var to use, mnemonic is too revealing
PatrickAlphaC
PatrickAlphaC suggested changes Oct 12, 2021
View reviewed changes
Copy link
Contributor

@PatrickAlphaC PatrickAlphaC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well now that we changed the default to the private key, we should update the readme.

I agree though, I think the private key is better than the whole mnemonic.

@pappas999
Copy link
Collaborator Author

Well now that we changed the default to the private key, we should update the readme.

I agree though, I think the private key is better than the whole mnemonic.

good catch, updated README pushed

@pappas999 pappas999 mentioned this pull request Oct 13, 2021
Closed
@PatrickAlphaC PatrickAlphaC merged commit 9e89acd into main Oct 19, 2021
@PatrickAlphaC PatrickAlphaC deleted the harry/add-tasks-back branch January 17, 2022 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabioDMFerreira fabioDMFerreira fabioDMFerreira approved these changes

@PatrickAlphaC PatrickAlphaC PatrickAlphaC approved these changes

@ryguardiano ryguardiano ryguardiano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pappas999 @ryguardiano @fabioDMFerreira @PatrickAlphaC