Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cifsacl fixes for replacing specific ACEs during chmod and chown #24

Merged
merged 2 commits into from
Feb 22, 2021
Merged

cifsacl fixes for replacing specific ACEs during chmod and chown #24

merged 2 commits into from
Feb 22, 2021

Commits on Feb 22, 2021

  1. cifs: Retain old ACEs when converting between mode bits and ACL. 

    When cifsacl mount option is used, retain the ACEs which
should not be modified during chmod. Following is the approach taken:

1. Retain all explicit (non-inherited) ACEs, unless the SID is one
of owner/group/everyone/authenticated-users. We're going to set new
ACEs for these SIDs anyways.
2. At the end of the list of explicit ACEs, place the new list of
ACEs obtained by necessary conversion/encoding.
3. Once the converted/encoded ACEs are set, copy all the remaining
ACEs (inherited) into the new ACL.

Signed-off-by: Shyam Prasad N <[email protected]>
    @sprasad-microsoft
    sprasad-microsoft committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    eaec39b View commit details
    Browse the repository at this point in the history

  2. cifs: Change SIDs in ACEs while transferring file ownership. 

    With cifsacl, when a file/dir ownership is transferred (chown/chgrp),
the ACEs in the DACL for that file will need to replace the old owner
SIDs with the new owner SID.

Signed-off-by: Shyam Prasad N <[email protected]>
    @sprasad-microsoft
    sprasad-microsoft committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    52d0afe View commit details
    Browse the repository at this point in the history