Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add skeleton codegen layout #177

Merged
merged 9 commits into from
Mar 10, 2023
Merged

Add skeleton codegen layout #177

merged 9 commits into from
Mar 10, 2023

Conversation

alex-chew
Copy link
Contributor

@alex-chew alex-chew commented Mar 9, 2023

Issue #, if available: Part of #151

Description of changes: Adds a skeleton of the Smithy plugin codegen layout as described in https://smithy.io/2.0/guides/building-codegen/creating-codegen-repo.html#codegen-repo-layout

Since there are no meaningful tests yet, I haven't added any CI workflows to this PR. But running ./gradlew :smithy-dafny-codegen:test does run the tests from DafnyClientCodegenPluginTest.java as expected.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@alex-chew alex-chew added the general-dafny-use New functionality or clean up for broader use of this repo label Mar 9, 2023
@alex-chew alex-chew requested a review from robin-aws March 9, 2023 00:49
@alex-chew alex-chew requested a review from a team as a code owner March 9, 2023 00:49
@robin-aws
Copy link
Contributor

Since there are no meaningful tests yet, I haven't added any CI workflows to this PR. But running ./gradlew :smithy-dafny-codegen:test does run the tests from DafnyClientCodegenPluginTest.java as expected.

Let's just add this to the end of smithy-polymorph.yml - it's still meaningful to test the thing builds at all :)

Copy link
Contributor

@robin-aws robin-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great!

@alex-chew alex-chew requested a review from robin-aws March 9, 2023 21:31
@alex-chew
Copy link
Contributor Author

alex-chew commented Mar 9, 2023

Oops - I still need to add the new tests to CI. (Done)

@alex-chew
Copy link
Contributor Author

This is now ready for review.

Copy link
Contributor

@robin-aws robin-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just want to let another existing code owner approve too.

Copy link
Contributor

@texastony texastony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would expect READMEs for smithy-dafny-codegen-test & smithy-dafny-codegen,
even just stubbed ones.

Or entries in the codegen/README.md for those directories.

But, as the repo matures, maybe the purpose of those directories will become more apperent.

Copy link
Contributor

@texastony texastony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@robin-aws robin-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@alex-chew alex-chew merged commit 688f6ed into main-1.x Mar 10, 2023
@alex-chew alex-chew deleted the smithy-plugin-skeleton branch March 10, 2023 22:01
robin-aws pushed a commit that referenced this pull request Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
general-dafny-use New functionality or clean up for broader use of this repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants