Support Super Fang & Ruination #576

ForwardFeed · 2023-08-23T11:46:00Z

And i've paid attention to round down if the HP are odd

shrianshChari · 2023-08-23T13:11:08Z

Nature's Madness seems to already be implemented, but you should also have this apply to Ruination as well because that move works the same way as Super Fang and Nature's Madness.

Additionally, Super Fang can hit Ghost types in Gen 1, so make sure that also gets implemented.

ForwardFeed · 2023-08-23T16:50:16Z

I'll work on it

…o '-'

ForwardFeed · 2023-08-25T07:34:05Z

Also two question, why aren't the genders fully implemented, i mean is there a specific reason for that? Also i plan to integrate Psywave & Magnitude, but i have no clue how to format the data, should i just show "Lowest BP Roll - Median BP roll - highest BP Roll ", or do like with multi-hits move where there is a menu on the BP rolls and the damage shows normally from there? thanks

lawauditswe · 2023-09-19T23:29:10Z

calc/src/mechanics/gen12.ts

I may be missing something but if defender.curHP() === 1, doesn't that mean lostHP === 0?

Super Fang should always do 1 damage at least, and will knock out a Pokemon with 1 HP.

Yes, but Math.floor(1 / 2) || 1 equals to 0 || 1 which evaluates to 1.

thejetou · 2023-09-29T21:38:47Z

calc/src/mechanics/gen12.ts

@@ -74,7 +74,13 @@ export function calculateRBYGSC(
    }
  }

-
+  //in gen 1, Super fang can hit ghosts


Suggested change

//in gen 1, Super fang can hit ghosts

// In Gen 1, Super Fang can hit Ghost types

thejetou · 2023-09-29T21:40:02Z

calc/src/mechanics/gen12.ts

+      const lostHP = Math.floor(defender.curHP() / 2) || 1;
+      result.damage = lostHP;
+      return result;
+  }


In Gen 2, you should check if the opposing Pokemon can be hit by Super Fang (probably by getMoveEffectiveness) and run the calculation if so.

And also check if the opposing Pokemon has Protect up just like it's done in gen789.ts.

In gen 2 the check for Super fang pass after the check of type effectiveness.

The same goes for the field.defenderSide.isProtected check, so as far i can tell, there is no issue with that.

In gen 2 the check for Super fang pass after the check of type effectiveness.

In Gen 2 Super Fang doesn't seem to be ran though.

The same goes for the field.defenderSide.isProtected check, so as far i can tell, there is no issue with that.

Yeah there is no issue there. My bad.

calc/src/mechanics/gen3.ts

thejetou · 2023-09-29T21:47:33Z

Also two question, why aren't the genders fully implemented, i mean is there a specific reason for that? Also i plan to integrate Psywave & Magnitude, but i have no clue how to format the data, should i just show "Lowest BP Roll - Median BP roll - highest BP Roll ", or do like with multi-hits move where there is a menu on the BP rolls and the damage shows normally from there? thanks

I'm not sure why the genders aren't full implemented either honestly, lol.

About Psywave & Magnitude, probably just format it "Lowest roll - Highest roll" and include each possible roll? I think that's sufficient.

ForwardFeed · 2023-10-13T21:08:10Z

Also for the gender, i was thinking more about the addSets and ExportPokemon in the front end. Rivalry and gender in the UI is well implemented, my bad i missexplained.
Also i slided a fix for something that has nothing to do about Halving HP moves, i have a doubt about if this is wrong.

…on#574)

Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap) from 1.2.3 to 1.2.4. - [Release notes](https://github.com/jonschlinkert/word-wrap/releases) - [Commits](jonschlinkert/word-wrap@1.2.3...1.2.4)

Bumps [semver](https://github.com/npm/node-semver) from 6.3.0 to 6.3.1. - [Release notes](https://github.com/npm/node-semver/releases) - [Changelog](https://github.com/npm/node-semver/blob/v6.3.1/CHANGELOG.md) - [Commits](npm/node-semver@v6.3.0...v6.3.1)

Fixes Spectral Thief stealing negative stat changes, as reported https://www.smogon.com/forums/posts/9748441. Additionally, fixes Spectral Thief not removing positive boosts (particularly Defense boosts) from the target.

In Generation 4, if a Pokemon with the ability Klutz holds an Iron Ball it should still get its Speed dropped. However, Klutz Pokemon holding an Iron Ball won't be grounded. Fixes smogon#560

Duplicate Palafin's sets into Palafin-Hero. Fixes smogon#558

The smoke tester runs PS battles and compares the damage rolls to the calc's. If they don't match, it will print the output to `logs/`. The smoke tester can then be re-ran with the log filename as a CLI argument and it will report each failure in detail. This is still a WIP as can be seen by the TODO comments but it works decently enough now that I decided to commit it to the repo.

https://www.smogon.com/forums/posts/9800504

Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.20.12 to 7.23.2. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.23.2/packages/babel-traverse) --- updated-dependencies: - dependency-name: "@babel/traverse" dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.21.2 to 7.23.2. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.23.2/packages/babel-traverse) --- updated-dependencies: - dependency-name: "@babel/traverse" dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

included damages for super fang

b40efad

ForwardFeed added 2 commits August 23, 2023 19:13

included previous gens, and gen one hit ghosts

efbbb0f

Added a fix where the move nature power was overwritting the nature t…

90024d1

…o '-'

lawauditswe reviewed Sep 19, 2023

View reviewed changes

thejetou reviewed Sep 29, 2023

View reviewed changes

thejetou changed the title ~~included damages for super fang~~ Support Super Fang & Ruination Sep 29, 2023

ForwardFeed and others added 19 commits October 13, 2023 23:14

quick text fix, thanks for pointing it out

2b53d0f

ups, eslint

4e1e2fa

Update sets

c239793

Update sets

e4cd27e

Update sets

d674289

Fix Gen 6 rands calc

8331869

Update template

1febdfa

Update sets

717bf06

Update sets

e76a352

Add Teal Mask DLC data

4d53b56

Add more Teal Mask DLC data

937a130

Support Mind's Eye

71aee62

Support Fairy Feather

c8f7aed

Support Ogerpon

eff650d

Support Ivy Cudgel

1334562

Remove console.log

de99a8f

Update @pkmn/dex

53f5e42

Fix typo that prevents blank sets from having default abilities (smog…

e18b638

…on#574)

Remove unused code

253a0a5

shrianshChari and others added 28 commits October 28, 2023 10:54

Fix "No matches found" in dark mode (smogon#580)

09d5819

Support Loaded Dice in the UI

4ff2635

Update sets

89d01b9

Implement default level selection (smogon#573)

e2aa5ac

Improve appearance of click-to-copy confirmation message (smogon#579)

13e5a9a

Remove duplicate spaces in the calc description (smogon#570)

226dcd7

Remove Enigma Berry from GSC only list (smogon#569)

1d016ff

Bump word-wrap from 1.2.3 to 1.2.4 in /calc (smogon#566)

894a5f0

Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap) from 1.2.3 to 1.2.4. - [Release notes](https://github.com/jonschlinkert/word-wrap/releases) - [Commits](jonschlinkert/word-wrap@1.2.3...1.2.4)

Bump word-wrap from 1.2.3 to 1.2.4 (smogon#565)

460e753

Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap) from 1.2.3 to 1.2.4. - [Release notes](https://github.com/jonschlinkert/word-wrap/releases) - [Commits](jonschlinkert/word-wrap@1.2.3...1.2.4)

Bump word-wrap from 1.2.3 to 1.2.4 in /import (smogon#564)

6e3f932

Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap) from 1.2.3 to 1.2.4. - [Release notes](https://github.com/jonschlinkert/word-wrap/releases) - [Commits](jonschlinkert/word-wrap@1.2.3...1.2.4)

UI: Fix Loaded Dice & Skill Link

30e5518

Fix Spectral Thief behavior (smogon#575)

1c8c382

Fixes Spectral Thief stealing negative stat changes, as reported https://www.smogon.com/forums/posts/9748441. Additionally, fixes Spectral Thief not removing positive boosts (particularly Defense boosts) from the target.

Gen 4: Fix Klutz not dropping Speed from Iron Ball (smogon#562)

07328a7

In Generation 4, if a Pokemon with the ability Klutz holds an Iron Ball it should still get its Speed dropped. However, Klutz Pokemon holding an Iron Ball won't be grounded. Fixes smogon#560

Update @pkmn/dex & package-lock.json (smogon#581)

b44f0ac

Import Palafin sets into Palafin-Hero (smogon#582)

f7d49b5

Duplicate Palafin's sets into Palafin-Hero. Fixes smogon#558

Update sets

89f6fc2

Fix Gen 5 Randoms damage calc

f6b2ee9

Update sets

fc8ee14

Heatproof is an attack modifier in SV

1ba2a46

https://www.smogon.com/forums/posts/9800504

Update sets

a26de83

Update sets

6b933d5

Add VGC2023 Regulation E

78ab355

Update sets

5e32c5b

Merge remote-tracking branch 'upstream/master'

e929667

thejetou mentioned this pull request Mar 7, 2024

Support Pain Split #585

Merged

AustinXII force-pushed the master branch from 3a174b6 to 843ff17 Compare July 2, 2024 03:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support Super Fang & Ruination #576

Support Super Fang & Ruination #576

ForwardFeed commented Aug 23, 2023

shrianshChari commented Aug 23, 2023

ForwardFeed commented Aug 23, 2023

ForwardFeed commented Aug 25, 2023

lawauditswe Sep 19, 2023

thejetou Sep 29, 2023 •

edited

Loading

thejetou Sep 29, 2023

thejetou Sep 29, 2023

ForwardFeed Oct 13, 2023

ForwardFeed Oct 13, 2023

thejetou Oct 13, 2023

thejetou commented Sep 29, 2023 •

edited

Loading

ForwardFeed commented Oct 13, 2023 •

edited

Loading

	//in gen 1, Super fang can hit ghosts
	// In Gen 1, Super Fang can hit Ghost types

Support Super Fang & Ruination #576

Are you sure you want to change the base?

Support Super Fang & Ruination #576

Conversation

ForwardFeed commented Aug 23, 2023

shrianshChari commented Aug 23, 2023

ForwardFeed commented Aug 23, 2023

ForwardFeed commented Aug 25, 2023

lawauditswe Sep 19, 2023

Choose a reason for hiding this comment

thejetou Sep 29, 2023 • edited Loading

Choose a reason for hiding this comment

thejetou Sep 29, 2023

Choose a reason for hiding this comment

thejetou Sep 29, 2023

Choose a reason for hiding this comment

ForwardFeed Oct 13, 2023

Choose a reason for hiding this comment

ForwardFeed Oct 13, 2023

Choose a reason for hiding this comment

thejetou Oct 13, 2023

Choose a reason for hiding this comment

thejetou commented Sep 29, 2023 • edited Loading

ForwardFeed commented Oct 13, 2023 • edited Loading

thejetou Sep 29, 2023 •

edited

Loading

thejetou commented Sep 29, 2023 •

edited

Loading

ForwardFeed commented Oct 13, 2023 •

edited

Loading